Quinta/benthicbloom
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix St.ImageContent.set_bytes missing Cogl.Context argument

Browse Source 
set_bytes() takes a Cogl.Context as its first parameter (added upstream
in GNOME Shell 48, see js/ui/screenshot.js); omitting it produced
"At least 6 arguments required, but only 5 passed" for every frame,
which fell through to the equally non-functional Clutter.Image fallback
and left the live wallpaper blank.
This commit is contained in:
Claude
2026-08-04 01:34:30 +00:00
parent 2365d303f3
commit bbd21c9e5a
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/liveWallpaper.js
+7 -1
View File
@@ -15,13 +15,19 @@ import {loadGstreamerModules, GSTREAMER_INSTALL_HINT} from './gstreamerAvailabil
* mechanism gnome-shell's own code uses for uploading raw pixel buffers — * mechanism gnome-shell's own code uses for uploading raw pixel buffers —
* is tried first, with the legacy Clutter.Image/set_data path kept only as * is tried first, with the legacy Clutter.Image/set_data path kept only as
* a fallback for older shells. * a fallback for older shells.
*
* St.ImageContent.set_bytes() takes a Cogl.Context as its first argument
* (see js/ui/screenshot.js upstream) — omitting it is what produced
* "At least 6 arguments required, but only 5 passed".
*/ */
const FRAME_IMAGE_STRATEGIES = [ const FRAME_IMAGE_STRATEGIES = [
{ {
name: 'St.ImageContent', name: 'St.ImageContent',
create: (width, height) => St.ImageContent.new_with_preferred_size(width, height), create: (width, height) => St.ImageContent.new_with_preferred_size(width, height),
upload: (image, Cogl, data, width, height) => upload: (image, Cogl, data, width, height) =>
image.set_bytes(GLib.Bytes.new(data), Cogl.PixelFormat.RGBA_8888, width, height, width * 4), image.set_bytes(
global.stage.context.get_backend().get_cogl_context(),
GLib.Bytes.new(data), Cogl.PixelFormat.RGBA_8888, width, height, width * 4),
}, },
{ {
name: 'Clutter.Image', name: 'Clutter.Image',